Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amazonq): /test align placeholder text across IDEs #5321

Merged
merged 4 commits into from
Feb 4, 2025
Merged

fix(amazonq): /test align placeholder text across IDEs #5321

merged 4 commits into from
Feb 4, 2025

Conversation

chungjac
Copy link
Contributor

@chungjac chungjac commented Feb 3, 2025 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • Placeholder texts are different between VSC and JB for /test
  • this updates the placeholder text so it is consistent for both after UTG Completion, UTG Reject, UTG Cancel

Screenshot 2025-02-03 at 2 42 22 PM
Screenshot 2025-02-03 at 2 43 30 PM
Screenshot 2025-02-03 at 2 43 52 PM

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested review from a team as code owners February 3, 2025 22:06
rli
rli approved these changes Feb 4, 2025
View reviewed changes
.changes/next-release/bugfix-8c569cf5-1a06-4bdc-b39b-91e04a6084b7.json Outdated
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : " /test placeholder text aligned across IDEs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description" : " /test placeholder text aligned across IDEs"
"description" : "/test placeholder text aligned across IDEs"

@chungjac chungjac enabled auto-merge (squash) February 4, 2025 17:51
@chungjac chungjac merged commit 0ab6d04 into aws:main Feb 4, 2025
10 checks passed
KevinDing1 pushed a commit to KevinDing1/aws-toolkit-jetbrains that referenced this pull request Feb 6, 2025
@chungjac @ashishrp-aws @KevinDing1
fix(amazonq): /test align placeholder text across IDEs (aws#5321)
631c81c 
* align placeholder text across IDEs

* Update description

---------

Co-authored-by: invictus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rli rli rli approved these changes

@ashishrp-aws ashishrp-aws ashishrp-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chungjac @rli @ashishrp-aws